Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change extension granularity from weeks to days #440

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

ublefo
Copy link
Contributor

@ublefo ublefo commented Apr 30, 2024

This has been a highly requested feature, providing better granularity for extensions improves flexibility for both the students and staff.

Summary of the changes:

  • New db migration to rename the db columns
  • Adjusted all extension related logic to use days instead of weeks
  • Adjusted all unit tests to reflect the change

Note: the "grant maximum number of allowed extensions when requested extension is longer than the limit" behavior has not been removed in this refactor, so if a student requests 7 days and the due date is 2 days away, only 2 days will be granted just like before. The removal of this behavior can be done at a later date.

Frontend changes: doubtfire-lms/doubtfire-web#830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant