fix crash with rescan-scsi-bus.sh -r #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Signed-off-by: Nitin U. Yewale nyewale@redhat.com this was missing. |
doug-gilbert
added a commit
that referenced
this pull request
Jan 3, 2022
… broken by rev 867 git-svn-id: https://svn.bingwo.ca/repos/sg3_utils/trunk@929 6180dd3e-e324-4e3e-922d-17de1ae2f315
|
Good catch. When I tried 'rescan-scsi-bus.sh -r' on my laptop, it removed all my SCSI devices. Luckily the root fs was on a NVMe SSD. Applied this patch upstream by hand (actually via 'wget /10.patch'). 'rescan-scsi-bus.sh -r' on my laptop is now better behaved. Your name is in the commit message and the CREDITS file. The fix should now be available here (it is in subversion revision 929). |
|
Thank you for everything. Regards, |
mwilck
pushed a commit
to openSUSE/sg3_utils-until-2023
that referenced
this pull request
Jan 4, 2022
…from Nitin U. Yewale, broken by rev 867 git-svn-id: https://svn.bingwo.ca/repos/sg3_utils/trunk@929 6180dd3e-e324-4e3e-922d-17de1ae2f315 Cherry-picked from upstream fc72119
mwilck
pushed a commit
to openSUSE/sg3_utils-until-2023
that referenced
this pull request
Jan 27, 2023
…from Nitin U. Yewale, broken by rev 867 git-svn-id: https://svn.bingwo.ca/repos/sg3_utils/trunk@929 6180dd3e-e324-4e3e-922d-17de1ae2f315
hreinecke
pushed a commit
to hreinecke/sg3_utils
that referenced
this pull request
Aug 17, 2023
…from Nitin U. Yewale, broken by rev 867 git-svn-id: https://svn.bingwo.ca/repos/sg3_utils/trunk@929 6180dd3e-e324-4e3e-922d-17de1ae2f315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System was crashing when 'rescan-scsi-bus.sh -r' was run. This is because of the changes in the output of
sg_inqcommand. In it, "Device_type" has been replaced with "PDT". So when Device_type is used in sed, it was passing incorrect return value to dolunscan() and hence even the internal disk from which system is booting was getting deleted. Mentioned fix takes care of both the outputs ofsg_inqcommand. Only in recentsg_inqwe see "PDT". Earliersg_inqstill shows "Device_type".