Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitwise operation #303

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Conversation

XIELongDragon
Copy link
Contributor

No description provided.

@XIELongDragon
Copy link
Contributor Author

@mattn please help to review this PR

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #303 (a9804f4) into master (72349ff) will decrease coverage by 0.70%.
The diff coverage is 74.31%.

❗ Current head a9804f4 differs from pull request most recent head 1e9f0ab. Consider uploading reports for the commit 1e9f0ab to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
- Coverage   96.81%   96.10%   -0.71%     
==========================================
  Files          61       62       +1     
  Lines        3355     3464     +109     
==========================================
+ Hits         3248     3329      +81     
- Misses         91      119      +28     
  Partials       16       16              
Flag Coverage Δ
unittests 96.10% <74.31%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exp/bitwise.go 35.71% <35.71%> (ø)
exp/exp.go 71.42% <92.85%> (+4.28%) ⬆️
dialect/mysql/mysql.go 100.00% <100.00%> (ø)
dialect/sqlite3/sqlite3.go 100.00% <100.00%> (ø)
dialect/sqlserver/sqlserver.go 100.00% <100.00%> (ø)
exp/ident.go 100.00% <100.00%> (ø)
exp/literal.go 100.00% <100.00%> (ø)
sqlgen/expression_sql_generator.go 100.00% <100.00%> (ø)
sqlgen/sql_dialect_options.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72349ff...1e9f0ab. Read the comment docs.

@XIELongDragon
Copy link
Contributor Author

@doug-martin fixed lint, please re-run the CI

@doug-martin
Copy link
Owner

@XIELongDragon re-ran to get the output from golang ci, the issues are not annotated in the PR.

@doug-martin doug-martin merged commit 0f17aca into doug-martin:master Oct 6, 2021
doug-martin added a commit that referenced this pull request Oct 6, 2021
* [Feature] Add support bitwise operations #303 - @XIELongDragon
@doug-martin doug-martin mentioned this pull request Oct 6, 2021
doug-martin added a commit that referenced this pull request Oct 6, 2021
* [Feature] Add support bitwise operations #303 - @XIELongDragon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants