feat(graphql): Expose setRelations mutation

doug-martin · Apr 13, 2021 · 676a4d5 · 676a4d5
1 parent 227d02d
commit 676a4d5
Show file tree

Hide file tree

Showing 6 changed files with 111 additions and 46 deletions.
diff --git a/...resolvers/relations/__fixtures__/update/update-relation-many-custom-name.resolver.graphql b/...resolvers/relations/__fixtures__/update/update-relation-many-custom-name.resolver.graphql
@@ -9,6 +9,7 @@ type Query {
 
 type Mutation {
   addTestsToTestResolverDTO(input: RelationsInput!): TestResolverDTO!
+  setTestsOnTestResolverDTO(input: RelationsInput!): TestResolverDTO!
 }
 
 input RelationsInput {

diff --git a/...l/__tests__/resolvers/relations/__fixtures__/update/update-relation-many.resolver.graphql b/...l/__tests__/resolvers/relations/__fixtures__/update/update-relation-many.resolver.graphql
@@ -9,6 +9,7 @@ type Query {
 
 type Mutation {
   addRelationsToTestResolverDTO(input: RelationsInput!): TestResolverDTO!
+  setRelationsOnTestResolverDTO(input: RelationsInput!): TestResolverDTO!
 }
 
 input RelationsInput {

diff --git a/packages/query-graphql/__tests__/resolvers/relations/update-relation.resolver.spec.ts b/packages/query-graphql/__tests__/resolvers/relations/update-relation.resolver.spec.ts
@@ -102,40 +102,99 @@ describe('UpdateRelationsResolver', () => {
         many: { relations: { DTO: TestRelationDTO, disableUpdate: true } },
       }));
 
-    it('should call the service findRelation with the provided dto and correct relation name', async () => {
-      const { resolver, mockService } = await createResolverFromNest(TestResolver);
-      const input: RelationsInputType = {
-        id: 'id-1',
-        relationIds: ['relation-id-1', 'relation-id-2'],
-      };
-      const output: TestResolverDTO = {
-        id: 'record-id',
-        stringField: 'foo',
-      };
-      when(mockService.addRelations('relations', input.id, deepEqual(input.relationIds), undefined)).thenResolve(
-        output,
-      );
-      // @ts-ignore
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-call
-      const result = await resolver.addRelationsToTestResolverDTO({ input });
-      return expect(result).toEqual(output);
+    describe('add relations', () => {
+      it('should call the service addRelations with the dto id and relationIds', async () => {
+        const { resolver, mockService } = await createResolverFromNest(TestResolver);
+        const input: RelationsInputType = {
+          id: 'id-1',
+          relationIds: ['relation-id-1', 'relation-id-2'],
+        };
+        const output: TestResolverDTO = {
+          id: 'record-id',
+          stringField: 'foo',
+        };
+        when(mockService.addRelations('relations', input.id, deepEqual(input.relationIds), undefined)).thenResolve(
+          output,
+        );
+        // @ts-ignore
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-call
+        const result = await resolver.addRelationsToTestResolverDTO({ input });
+        return expect(result).toEqual(output);
+      });
+
+      it('should call the service addRelations with the custom dto name dto id and relationIds', async () => {
+        const { resolver, mockService } = await createResolverFromNest(TestResolver);
+        const input: RelationsInputType = {
+          id: 'id-1',
+          relationIds: ['relation-id-1', 'relation-id-2'],
+        };
+        const output: TestResolverDTO = {
+          id: 'record-id',
+          stringField: 'foo',
+        };
+        when(mockService.addRelations('others', input.id, deepEqual(input.relationIds), undefined)).thenResolve(output);
+        // @ts-ignore
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-call
+        const result = await resolver.addCustomsToTestResolverDTO({ input });
+        return expect(result).toEqual(output);
+      });
     });
 
-    it('should call the service findRelation with the provided dto and custom relation name', async () => {
-      const { resolver, mockService } = await createResolverFromNest(TestResolver);
-      const input: RelationsInputType = {
-        id: 'id-1',
-        relationIds: ['relation-id-1', 'relation-id-2'],
-      };
-      const output: TestResolverDTO = {
-        id: 'record-id',
-        stringField: 'foo',
-      };
-      when(mockService.addRelations('others', input.id, deepEqual(input.relationIds), undefined)).thenResolve(output);
-      // @ts-ignore
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-call
-      const result = await resolver.addCustomsToTestResolverDTO({ input });
-      return expect(result).toEqual(output);
+    describe('set relations', () => {
+      it('should call the service setRelations with the dto id and relationIds', async () => {
+        const { resolver, mockService } = await createResolverFromNest(TestResolver);
+        const input: RelationsInputType = {
+          id: 'id-1',
+          relationIds: ['relation-id-1', 'relation-id-2'],
+        };
+        const output: TestResolverDTO = {
+          id: 'record-id',
+          stringField: 'foo',
+        };
+        when(mockService.setRelations('relations', input.id, deepEqual(input.relationIds), undefined)).thenResolve(
+          output,
+        );
+        // @ts-ignore
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-call
+        const result = await resolver.setRelationsOnTestResolverDTO({ input });
+        return expect(result).toEqual(output);
+      });
+
+      it('should call the service setRelations with the dto id and an empty relationIds', async () => {
+        const { resolver, mockService } = await createResolverFromNest(TestResolver);
+        const input: RelationsInputType = {
+          id: 'id-1',
+          relationIds: [],
+        };
+        const output: TestResolverDTO = {
+          id: 'record-id',
+          stringField: 'foo',
+        };
+        when(mockService.setRelations('relations', input.id, deepEqual(input.relationIds), undefined)).thenResolve(
+          output,
+        );
+        // @ts-ignore
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-call
+        const result = await resolver.setRelationsOnTestResolverDTO({ input });
+        return expect(result).toEqual(output);
+      });
+
+      it('should call the service setRelations with the custom dto name dto id and relationIds', async () => {
+        const { resolver, mockService } = await createResolverFromNest(TestResolver);
+        const input: RelationsInputType = {
+          id: 'id-1',
+          relationIds: ['relation-id-1', 'relation-id-2'],
+        };
+        const output: TestResolverDTO = {
+          id: 'record-id',
+          stringField: 'foo',
+        };
+        when(mockService.setRelations('others', input.id, deepEqual(input.relationIds), undefined)).thenResolve(output);
+        // @ts-ignore
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-call
+        const result = await resolver.setCustomsOnTestResolverDTO({ input });
+        return expect(result).toEqual(output);
+      });
     });
   });
 });
diff --git a/packages/query-graphql/__tests__/types/relations-input.type.spec.ts b/packages/query-graphql/__tests__/types/relations-input.type.spec.ts
@@ -61,21 +61,11 @@ describe('RelationsInputType', (): void => {
       ]);
     });
 
-    it('should validate that relationsIds is not empty', () => {
+    it('should allow an empty relationIds array', () => {
       const input: RelationsInputType = { id: 1, relationIds: [] };
       const it = plainToClass(RelationsInput, input);
       const errors = validateSync(it);
-      expect(errors).toEqual([
-        {
-          children: [],
-          constraints: {
-            arrayNotEmpty: 'relationIds should not be empty',
-          },
-          property: 'relationIds',
-          target: input,
-          value: input.relationIds,
-        },
-      ]);
+      expect(errors).toEqual([]);
     });
 
     it('should validate that relationsIds is unique', () => {

diff --git a/packages/query-graphql/src/resolvers/relations/update-relations.resolver.ts b/packages/query-graphql/src/resolvers/relations/update-relations.resolver.ts
@@ -78,6 +78,21 @@ const UpdateManyRelationMixin = <DTO, Relation>(DTOClass: Class<DTO>, relation:
       const { input } = await transformAndValidate(AddArgs, addArgs);
       return this.service.addRelations(relationName, input.id, input.relationIds, modifyRelationsFilter);
     }
+
+    @ResolverMutation(() => DTOClass, {}, commonResolverOpts, {
+      interceptors: [AuthorizerInterceptor(DTOClass)],
+    })
+    async [`set${pluralBaseName}On${dtoNames.baseName}`](
+      @Args() addArgs: AddArgs,
+      @ModifyRelationAuthorizerFilter(pluralBaseNameLower, {
+        operationGroup: OperationGroup.UPDATE,
+        many: true,
+      })
+      modifyRelationsFilter?: ModifyRelationOptions<DTO, Relation>,
+    ): Promise<DTO> {
+      const { input } = await transformAndValidate(AddArgs, addArgs);
+      return this.service.setRelations(relationName, input.id, input.relationIds, modifyRelationsFilter);
+    }
   }
   return UpdateManyMixin;
 };

diff --git a/packages/query-graphql/src/types/relations-input.type.ts b/packages/query-graphql/src/types/relations-input.type.ts
@@ -1,6 +1,6 @@
 import { Class } from '@nestjs-query/core';
 import { Field, ID, InputType } from '@nestjs/graphql';
-import { IsNotEmpty, ArrayNotEmpty, ArrayUnique } from 'class-validator';
+import { IsNotEmpty, ArrayUnique } from 'class-validator';
 
 export interface RelationsInputType {
   id: string | number;
@@ -21,7 +21,6 @@ export function RelationsInputType(): Class<RelationsInputType> {
     id!: string | number;
 
     @Field(() => [ID], { description: 'The ids of the relations.' })
-    @ArrayNotEmpty()
     @ArrayUnique()
     @IsNotEmpty({ each: true })
     relationIds!: (string | number)[];