Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Relations with ReadResolver can't query relations #42

Closed
izundo-viennv opened this issue Feb 29, 2020 · 1 comment
Closed
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@izundo-viennv
Copy link

@doug-martin I created a resolver extends from ReadResolver but it doesn't doesn't generate schema for query relations

@doug-martin doug-martin changed the title [Bug] Relations with ReadResolver can't query relations [Question] Relations with ReadResolver can't query relations Feb 29, 2020
@doug-martin doug-martin added question Further information is requested enhancement New feature or request labels Feb 29, 2020
@doug-martin
Copy link
Owner

I went back and forth on whether or not the read resolver should automatically add relations. When using the read resolver by itself its picking a la carte functionality.

Looking at the source I see that I dont expose the Relateable mixin....Ill look into either exposing that or automatically adding the read relations.

The reason I wavered, was that It was unclear where the add/remove relations belonged, and I felt it kinda broke the single responsibility of the Read Resolver.

@doug-martin doug-martin added this to the v0.5.1 milestone Mar 2, 2020
doug-martin added a commit that referenced this issue Mar 2, 2020
* [DOCS] Added clarification around individual resolvers and relations with examples #42
* [ADDED] Exposed `Relatable` mixin from `@nestjs-query/graphql` #42
doug-martin added a commit that referenced this issue Mar 3, 2020
* [DOCS] Added clarification around individual resolvers and relations with examples #42
* [ADDED] Exposed `Relatable` mixin from `@nestjs-query/graphql` #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants