Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use setAttribute rather than rerendering #134

Closed
doug-wade opened this issue Dec 20, 2022 · 1 comment
Closed

use setAttribute rather than rerendering #134

doug-wade opened this issue Dec 20, 2022 · 1 comment
Labels
core enhancement New feature or request

Comments

@doug-wade
Copy link
Owner

Currently, we perform a full re-render if any observable returned from the setup function emits. We'd rather call setAttribute and reuse the DOM.
@doug-wade doug-wade added enhancement New feature or request core labels Jan 8, 2023
@doug-wade doug-wade changed the title core: use setAttribute rather than rerendering use setAttribute rather than rerendering Jan 8, 2023
@doug-wade doug-wade mentioned this issue Jul 29, 2023
Open
@doug-wade
Copy link
Owner Author

https://github.com/WICG/webcomponents/blob/gh-pages/proposals/DOM-Parts.md

doug-wade added a commit that referenced this issue Dec 17, 2023
@doug-wade
feat(#134): use setAttribute rather than doing a full re-render
2525f6a
doug-wade added a commit that referenced this issue Dec 17, 2023
@doug-wade
feat(#134): use setAttribute rather than doing a full re-render
9d1ef0d
doug-wade added a commit that referenced this issue Dec 17, 2023
@doug-wade
feat(#134): Add reactive documentation to the sidebar
349089d
doug-wade added a commit that referenced this issue Dec 17, 2023
@doug-wade
feat(#134): Fix type checking errors
efbb775
doug-wade added a commit that referenced this issue Dec 17, 2023
@doug-wade
feat(#134): Fix linting errors
b6dcf68
doug-wade added a commit that referenced this issue Dec 17, 2023
@doug-wade
feat(#134): use setAttribute rather than doing a full re-render
bc95943
doug-wade added a commit that referenced this issue Dec 17, 2023
@doug-wade
feat(#134): Add reactive documentation to the sidebar
9af947c
doug-wade added a commit that referenced this issue Dec 17, 2023
@doug-wade
feat(#134): Fix type checking errors
3207654
doug-wade added a commit that referenced this issue Dec 17, 2023
@doug-wade
feat(#134): Fix linting errors
d7a712a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@doug-wade