Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something is wrong with our dns #356

Closed
doug-wade opened this issue Aug 2, 2023 · 5 comments
Closed

Something is wrong with our dns #356

doug-wade opened this issue Aug 2, 2023 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@doug-wade
Copy link
Owner

Every time we deploy, I have to re-set the custom domains on settings > pages, which it doesn't seem like I should have to do. Maybe we need a CNAME file?

doug-wade added a commit that referenced this issue Aug 3, 2023
See if this fixes our DNS issues.
@doug-wade doug-wade self-assigned this Aug 3, 2023
doug-wade added a commit that referenced this issue Aug 3, 2023
See if this fixes our DNS issues.
@doug-wade
Copy link
Owner Author

The CNAME does not seem to have helped

@doug-wade doug-wade removed their assignment Aug 8, 2023
@doug-wade doug-wade added bug Something isn't working help wanted Extra attention is needed labels Aug 8, 2023
@doug-wade
Copy link
Owner Author

When we're having an outage, there is no CNAME file on the gh-pages branch, and updating the field adds one

@ysfchn
Copy link

ysfchn commented Aug 9, 2023

Just came across this issue from Mastodon, and thought I could help!

I guess that peaceiris/actions-gh-pages GitHub Action clears out the gh-pages branch completely before starting to deploy, so I guess it won't matter if you manually add CNAME here, as it will be deleted again in the next deploy.

Instead, you should create/generate a CNAME file in the output directory (publish_dir), in this case ./packages/website/_site, so all files including the CNAME file itself will be committed to gh-pages in the next deploy.

publish_dir: ./packages/website/_site

Alternatively, there is a cname option in the action.

cname: www.tybalt.org

You can also check the other configuration options of the action, such as excluding specific files to prevent the action from deleting CNAME.

Hope this helps!

@doug-wade
Copy link
Owner Author

Thanks for stopping by @ysfchn -- I tried that and just had my first clean deploy! Thanks so much!

@ysfchn
Copy link

ysfchn commented Aug 9, 2023

Glad I was able to help! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants