Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide names have dashes in their titles #405

Closed
doug-wade opened this issue Aug 12, 2023 · 3 comments · Fixed by #429
Closed

Guide names have dashes in their titles #405

doug-wade opened this issue Aug 12, 2023 · 3 comments · Fixed by #429
Assignees
Labels
bug Something isn't working good first issue Good for newcomers website

Comments

@doug-wade
Copy link
Owner

Screenshot 2023-08-12 at 8 32 48 AM
@doug-wade doug-wade added bug Something isn't working website good first issue Good for newcomers labels Aug 12, 2023
@doug-wade
Copy link
Owner Author

We need to add a .replace('-', ' ') to guide at this line:

<tybalt-link href="/pages/${guide}-guide">${guide} guide</tybalt-link>

@Ashvith10
Copy link
Contributor

@doug-wade personal opinion, but I think we should remove the preceding "guide" as well, as it is redundant. Could you assign this to me btw?

@doug-wade
Copy link
Owner Author

Makes sense to me -- having a guide suffix under a guide header does seem redundant. Assigned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers website
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants