Clone serialize deadcode (#17)

* Refactor: Adding Serialize and Clone. Removed deadcode warning

Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "fireblocks-sdk"
 resolver = "2"
-version = "0.3.0"
+version = "0.3.1"
 authors = ["Doug Chimento <dchimento@gmail.com>"]
 description = "Rust implementation of the Fireblocks SDK"
 readme = "README.md"
@@ -20,7 +20,7 @@ crate-type = ["cdylib", "rlib"]
 
 [lints.rust]
 unsafe_code = "forbid"
-dead_code = "allow"
+
 
 [lints.clippy]
 enum_glob_use = "deny"

src/api/mod.rs

@@ -1,7 +1,8 @@
-use serde_derive::Serialize;
+use serde_derive::{Deserialize, Serialize};
 
 mod contracts;
 mod external_wallets;
+mod hooks;
 mod internal_wallets;
 mod staking;
 mod transactions;
@@ -19,3 +20,8 @@ pub struct WalletCreateAsset {
   pub address: String,
   pub tag: String,
 }
+
+#[derive(Debug, Deserialize, Default)]
+pub struct Success {
+  pub success: bool,
+}

src/api/vaults.rs

@@ -1,18 +1,14 @@
+use crate::api::Success;
 use crate::types::{
   Account, Address, AddressContainer, CreateAccount, CreateAddressResponse, PaginatedAssetWallet, VaultAccounts,
   VaultRenameResponse,
 };
 use crate::Client;
 use crate::Result;
-use serde_derive::{Deserialize, Serialize};
+use serde_derive::Serialize;
 use std::borrow::Borrow;
 use std::fmt::{Debug, Display};
 
-#[derive(Debug, Deserialize, Default)]
-struct Success {
-  success: bool,
-}
-
 impl Client {
   /// Create an asset (address) for a vault account
   ///

src/lib.rs

@@ -314,20 +314,19 @@ mod tests {
     if !config.is_ok() {
       return Ok(());
     }
+    let c = config.client();
     let name = format!("c-{}", vault_name());
-    let (contract_response, id) = config.client().contract_create(&name).await?;
+    let (contract_response, id) = c.contract_create(&name).await?;
     assert!(!id.is_empty());
     assert_eq!(contract_response.name, name);
     assert!(!contract_response.id.is_empty());
 
-    let (addr_response, _) = config
-      .client()
-      .contract_asset(&contract_response.id, ASSET_ETH_TEST, "0x9bb4d44e6963260a1850926e8f6beb8d5803836f")
-      .await?;
+    let (addr_response, _) =
+      c.contract_asset(&contract_response.id, ASSET_ETH_TEST, "0x9bb4d44e6963260a1850926e8f6beb8d5803836f").await?;
     assert_eq!(addr_response.id, ASSET_ETH_TEST);
-
-    config.client().contract_delete(&name).await?;
-    config.client().contracts().await?;
+    c.contract(&contract_response.id).await?;
+    c.contract_delete(&name).await?;
+    c.contracts().await?;
     Ok(())
   }
 
@@ -423,7 +422,15 @@ mod tests {
     if !config.is_ok() {
       return Ok(());
     }
-    config.client().wallet_connections().await?;
+    let c = config.client();
+    c.wallet_connections().await?;
+    if let Err(e) = c.wallet_connection_delete("wallet-connect-id").await {
+      assert!(e.to_string().contains("wallet-connect-id not found"));
+    }
+
+    if let Err(e) = c.wallet_connection_approve("wallet-connect-id", true).await {
+      assert!(e.to_string().contains("wallet-connect-id not found"));
+    }
     Ok(())
   }
 
@@ -496,6 +503,33 @@ mod tests {
     Ok(())
   }
 
+  #[rstest::rstest]
+  #[tokio::test]
+  async fn test_hooks(config: Config) -> color_eyre::Result<()> {
+    if !config.is_ok() {
+      return Ok(());
+    }
+    let c = config.client();
+    match c.hooks_resend().await {
+      Ok(result) => {
+        assert!(result.0.message_count > 0);
+      },
+      Err(e) => {
+        assert!(e.to_string().contains("Internal Fireblocks Error"));
+      },
+    };
+
+    match c.hooks_resend_tx("e01b1c68-2d26-45dc-bb02-4cc9152295e1", true, true).await {
+      Err(e) => {
+        assert!(e.to_string().contains("Internal Fireblocks Error"));
+      },
+      Ok(result) => {
+        assert!(result.0.success);
+      },
+    }
+    Ok(())
+  }
+
   #[rstest::rstest]
   #[tokio::test]
   async fn test_paged_transactions(config: Config) -> color_eyre::Result<()> {

src/types/address.rs

@@ -31,23 +31,20 @@ where
 
 #[derive(Debug, Serialize, Deserialize, Default)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct AddressContainer {
   pub addresses: Vec<Address>,
   pub paging: Option<Paging>,
 }
 
 #[derive(Debug, Serialize, Deserialize, Clone, Default)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct CreateAddressResponse {
   pub id: String,
   pub address: String,
 }
 
 #[derive(Debug, Serialize, Deserialize, Clone, Default)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct Address {
   pub asset_id: Asset,
   pub address: String,

src/types/asset.rs

@@ -5,7 +5,6 @@ use serde_derive::{Deserialize, Serialize};
 
 #[derive(Debug, Serialize, Deserialize, Clone, Default)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct SupportedAsset {
   pub id: Asset,
   pub name: String,
@@ -18,7 +17,6 @@ pub struct SupportedAsset {
 
 #[derive(Debug, Deserialize)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct AssetResponse {
   #[serde(deserialize_with = "deserialize_str_u64", default)]
   pub vault_id: u64,
@@ -34,7 +32,6 @@ pub struct AssetResponse {
 
 #[derive(Debug, Serialize, Deserialize, Default, Clone)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct AccountAsset {
   pub id: String,
   pub total: BigDecimal,

src/types/connect.rs

@@ -3,7 +3,6 @@ use serde_derive::{Deserialize, Serialize};
 
 #[derive(Debug, Deserialize, Serialize, Default)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct Metadata {
   pub app_url: String,
   pub app_name: String,
@@ -14,7 +13,6 @@ pub struct Metadata {
 
 #[derive(Debug, Deserialize, Serialize, Default)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct WalletConnection {
   pub id: String,
   #[serde(rename = "userId")]
@@ -33,30 +31,26 @@ pub struct WalletConnection {
 
 #[derive(Debug, Deserialize, Serialize, Default)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct NextPage {
   pub next: String,
 }
 
 #[derive(Debug, Deserialize, Serialize, Default)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct PagedWalletConnectResponse {
   pub data: Vec<WalletConnection>,
   pub page: Option<NextPage>,
 }
 
 #[derive(Debug, Deserialize, Serialize, Default)]
 #[serde(rename_all = "SCREAMING_SNAKE_CASE")]
-#[allow(dead_code)]
 pub enum FeeLevel {
   #[default]
   Medium,
 }
 
 #[derive(Debug, Deserialize, Serialize, Default)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct WalletConnectRequest {
   pub fee_level: FeeLevel,
   pub vault_account_id: i32,
@@ -66,14 +60,12 @@ pub struct WalletConnectRequest {
 
 #[derive(Debug, Deserialize, Serialize, Default)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct WalletConnectResponse {
   pub id: String,
 }
 
 #[derive(Debug, Deserialize, Serialize, Default)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct WalletApprove {
   pub approve: bool,
 }

src/types/fee.rs

@@ -3,7 +3,6 @@ use serde::Deserialize;
 
 #[derive(Debug, Deserialize, Default)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct Fee {
   pub network_fee: Option<BigDecimal>,
   pub gas_price: Option<BigDecimal>,
@@ -14,7 +13,6 @@ pub struct Fee {
 
 #[derive(Debug, Deserialize, Default)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct EstimateFee {
   pub low: Fee,
   pub medium: Fee,

src/types/mod.rs

@@ -8,6 +8,7 @@ pub mod address;
 pub mod asset;
 pub mod connect;
 pub mod fee;
+pub mod hooks;
 mod page;
 pub mod staking;
 pub mod transaction;
@@ -66,7 +67,6 @@ where
 
 #[derive(Debug, Deserialize, Default)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct PaginatedAssetWallet {
   pub asset_wallets: Vec<AssetResponse>,
   pub paging: Paging,

src/types/page.rs

@@ -4,7 +4,6 @@ use serde_derive::{Deserialize, Serialize};
 
 #[derive(Debug, Deserialize, Serialize, Default)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 pub struct Paging {
   pub before: Option<String>,
   pub after: Option<String>,