Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake version #124

Closed
erincatto opened this issue Apr 25, 2024 · 2 comments
Closed

CMake version #124

erincatto opened this issue Apr 25, 2024 · 2 comments

Comments

@erincatto
Copy link
Contributor

I'm seeing this all the time lately using enkiTS via CMake.

CMake Deprecation Warning at build/_deps/enkits-src/CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.

Update the VERSION argument value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.

It would helpful to bump the version to 3.5. I tested this and it seems fine. I'd submit a PR, but it is a one line change.

@dougbinks
Copy link
Owner

Thanks for this issue report - I'm happy to receive a PR if you want your name in the commit log, but I'm equally happy just to make the change myself.

@erincatto
Copy link
Contributor Author

See #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants