Minor refactoring: Get rid of unnecessary expensive getElementById ca…

…lls. Images don't need any id then. Closer to initial code from Douglas this way again.
douglasbagnall · Oct 7, 2014 · 945c684 · 945c684
1 parent 7c8ba6c
commit 945c684
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/display.js b/src/display.js
@@ -267,7 +267,6 @@ _p4d_proto.write_board_html = function(){
             img.src = P4WN_IMAGE_DIR + '/' + P4WN_IMAGE_NAMES[0];
             img.width= P4WN_SQUARE_WIDTH;
             img.height= P4WN_SQUARE_HEIGHT;
-            img.id= 'field' + (((y-2) << 3) + x-1);
         }
     }
 };

diff --git a/src/resolutionawareness.js b/src/resolutionawareness.js
@@ -24,10 +24,13 @@ function displayResize(evt) {
   P4WN_SQUARE_WIDTH = tmp_square;
   P4WN_SQUARE_HEIGHT = tmp_square;
   game.render_elements();
-  for (var i=0; i<64; ++i) {
-    var element = this.document.getElementById('field' + i)
-    element.height = tmp_square;
-    element.width = tmp_square;
+  var pieces = game.elements.pieces;
+  for (var y = 9; y > 1; y--){
+    for(var x = 1;  x < 9; x++){
+      var i = y * 10 + x;
+      pieces[i].height = tmp_square;
+      pieces[i].width = tmp_square;
+    }
   }
 }