-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds get_attribute and get_cookies method #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used to get attributes such as class, aria-label, aria-valuenow, etc.
tomasserravento
changed the title
Adds get_attribute method
Adds get_attribute async method
Jun 4, 2023
tomasserravento
changed the title
Adds get_attribute async method
Adds get_attribute method
Jun 4, 2023
tomasserravento
changed the title
Adds get_attribute method
Adds get_attribute and get_cookies method
Jun 4, 2023
Thanks a lot @tomasserravento for this contribution. Can you add the unit tests for all functions, please? I'm trying to keep a high code coverage. There are many examples for synchronous and asynchronous functions. If you have any issue, please let me know |
Hey, just added the unit tests @douglasdcm . I hope they are okay!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to get attributes such as class, aria-label, aria-valuenow, etc.
I have been using caqui and for now it works perfectly. I needed to get the attribute of an element but I couldnt find a method to do so, so here it is. I have tested it and it works fine.
Thanks for the work here!