Podspec added #24
Merged
Podspec added #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Added instructions to Readme |
douglasjunior
requested changes
Apr 19, 2018
| s.preserve_paths = 'README.md', 'package.json', '*.js' | ||
| s.source_files = 'ios/ReactNativeKeyboardManager/**/*.{h,m}' | ||
| s.dependency 'React' | ||
| s.dependency 'IQKeyboardManager' |
There was a problem hiding this comment.
s.dependency 'IQKeyboardManager'
This dependency of the IQKeyboardManager make Cocopods to install it again?
Because the IQKeyboardManager is already included in the source code.
|
Yep, I've seen. In case when user uses cocoapods it will be handled by it, otherwise it will use your, included IQKeyboardManager. It's actually a one and only proper way to handle dependencies in cocoapods. UPD: and yep, it works with charm this way =) |
|
Great, thanks. |
Closed
|
I'm going to release a version in a few hours. |
|
@douglasjunior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a proper podspec for using with cocoapods.
Actually, this is the only way to link the library with project without suffering and this shitty
"<RCT***.h> not found" errors
Usage:
pod 'RNKeyboardManager', :path => '../node_modules/react-native-keyboard-manager'