Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS URL Rewrite and CSS Asset Copier #73

Merged
merged 14 commits into from
Oct 24, 2016
Merged

Conversation

sormy
Copy link
Contributor

@sormy sormy commented Oct 16, 2016

General Goal: CSS URL Rewrite and CSS Asset Copier

Example:

  • URL to all assets should be rewritten to load them correctly
  • bundle operation should copy assets into destination folder
import 'font-awesome/scss/font-awesome.scss';
import 'open-sans/open-sans.scss';

Fixes:

  • modernizer removed, detection of Worker could be easier with one line window.Worker
  • css url rewrite
  • css asset copier
  • separate css option
  • build css option
  • pass autoprefixer options
  • refactoring
  • fix lining
  • unify css injector
  • readme fixes
  • minify based on bundler options

Copy link
Collaborator

@screendriver screendriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make tests for the newly added features?

By the way: thank you! Great work 👍 😎

@sormy
Copy link
Contributor Author

sormy commented Oct 22, 2016

  • css url rewriter and css asset copier are covered by unit tests in their repos
  • for functional tests I fixed tests which you already have here

Let me know if I need to cover something else by tests.

@screendriver screendriver merged commit fd75b3d into dougludlow:master Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants