Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I translated the new game menu strings to russian language #51

Merged
merged 2 commits into from
Oct 4, 2023
Merged

I translated the new game menu strings to russian language #51

merged 2 commits into from
Oct 4, 2023

Conversation

VadiqueMe
Copy link
Contributor

and I slightly modified the game's font for a better look of cyrillic "у"

and I made the russian letter "ё" (йо, yo) to render as "e umlaut" not as "?"

#31 ( #31 )

and I slightly modified the game's font for a better look of cyrillic "у"

and I made the russian letter "ё" (йо, yo) to render as "e umlaut" not as "?"

#31 ( #31 )
@dougmencken
Copy link
Owner

thanks

but since I’m not an expert in Russian, can you tell me what’s the deal with changing same to the same here ?

if ( letter == "ё" ) letterInTable = "ë" ;

@VadiqueMe
Copy link
Contributor Author

what’s the deal with changing same to the same here ?

if ( letter == "ё" ) letterInTable = "ë" ;

these are not the same, and without such a change the font has nothing for "ё" letter and renders a question mark instead
Screenshot from 2023-10-04 21-41-40

@VadiqueMe
Copy link
Contributor Author

but yes, it looks confusing and undistinguishable, maybe I need to write unicode codes instead

\u0401 cyrillic capital letter IO — \u00CB latin capital letter E with diaeresis
\u0451 cyrillic small letter io — \u00EB latin small letter e with diaeresis

@dougmencken
Copy link
Owner

maybe I need to write unicode codes instead

yes, please

@VadiqueMe
Copy link
Contributor Author

maybe I need to write unicode codes instead

yes, please

yo yo

-                if ( letter == "ё" ) letterInTable = "ë" ;
-                if ( letter == "Ё" ) letterInTable = "Ë" ;
+                if ( letter == "\u0451" ) letterInTable = "\u00EB" ; // \u0451 cyrillic small letter io — \u00EB latin small letter e with diaeresis
+                if ( letter == "\u0401" ) letterInTable = "\u00CB" ; // \u0401 cyrillic capital letter IO — \u00CB latin capital letter E with diaeresis
-      <string>Новая игра</string>
+      <string>Новая Ё ё игра ё Ё</string>

Screenshot from 2023-10-04 22-17-48

sure
   if ( letter == "ё" ) letterInTable = "ë" ;
looks confusing and undistinguishable ("what’s the deal with changing same to the same here" ~Douglas :)

in addition, I translated the "Keyboard" menu better
@dougmencken dougmencken merged commit 1d52687 into dougmencken:master Oct 4, 2023
@dougmencken
Copy link
Owner

merged it, happy hackin'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants