Decaying homogeneous isotropic turbulence #194

jbrillon · 2023-02-11T03:09:24Z

PR to incorporate the DHIT flow test case and the added features associated with it.

Summary of features:

Initialize solution from a file; for DHIT use https://github.com/jbrillon/DHIT-Flow-Setup
Output velocity field files at given times (for generating turbulent kinetic energy spectrum plots in post-processing using https://github.com/jbrillon/PHiLiP-Post-Processing)
Navier-Stokes can be ran for a constant viscosity if desired
LES filter width has been corrected to filter_width = pow(cell_volume, (1.0/3.0))/(cell_poly_degree+1)
Closed issue Use PhysicsBase's implementation of boundary_face_values in derived classes #72
Added tests homogeneous_isotropic_turbulence_initialization_check which tests the file reader for initializing the solution within the projection loop -- this will fail if the coordinates (x,y,z) and state (s) do not match what PHiLiP expects as it is performing the loop

…akes use of operators in DG strong. Provides weight-adjusted curvilinear Mass matrices. Includes free-stream preserving metric terms.

…ougshidong-master_esfr

… into 1.

…d #if 0 #endif commented blocks.

…ed new numerical fluxes in the numerical_flux_conservation test.

dg.cpp minor edits

…be written as a combination of matrix-vector products and inner products. A unit test verifies by testing the cputime for A*u and also M*u where M is a mass matrix--uses both matrix-vector product and inner product forms. All that is left is to clean up the unit test a bit to fail at wrong orders.

…ge conflict with ode solver base then pull request changes complete.

Sum factorization branch

…ougshidong-master_Apr20

…. Updated unsteady tests. Continued to clean up and removed deprecated Burgers Rewienski lines.

…operators and flags.

…re collections from DG. Made consistent throughout the code to call operators finite element and quadrature collections from the operators collection tuple.

…ougshidong-master

…capabilities for different initial condition functions. This generalizes the initial condition class.

src/physics/euler.cpp

jbrillon · 2023-02-14T21:30:15Z

All tests that should be passing are passing

ctest_2023-02-13.txt

cpethrick

Great work! I have left a few comments.

I saw that there is an option to output the results on equidistant nodes. Have you checked whether there is significant interpolation error when reading/writing to different nodes? I.e. would solution --write--> file --read--> solution recover the initial solution?

src/dg/artificial_dissipation.h

src/flow_solver/flow_solver.cpp

src/flow_solver/flow_solver_cases/periodic_turbulence.cpp

src/physics/euler.cpp

src/flow_solver/flow_solver_cases/periodic_turbulence.cpp

src/physics/initial_conditions/set_initial_condition.cpp

jbrillon · 2023-02-16T18:09:56Z

as we discussed, output_velocity_field with the equidistant nodes is only used for post-processing and not for generating an input file; the input file must match the expected node coordinates and the reader will fail if they don't

…s-isotropic-turbulence

cpethrick

Approving as all my comments have been addressed!

…s-isotropic-turbulence

PranshulThakur

Nice PR to introduce DHIT. I have added a few comments and will approve it soon.

src/flow_solver/flow_solver.cpp

src/flow_solver/flow_solver_cases/periodic_turbulence.cpp

src/testing/homogeneous_isotropic_turbulence_initialization_check.cpp

sivanadarajah · 2023-02-17T21:43:13Z

PR to incorporate the DHIT flow test case and the added features associated with it.

Summary of features:

Initialize solution from a file

Output velocity field files at given times (for generating turbulent kinetic energy spectrum plots in post-processing using https://github.com/jbrillon/PHiLiP-Post-Processing)

Navier-Stokes can be ran for a constant viscosity if desired

LES filter width has been corrected to filter_width = pow(cell_volume, (1.0/3.0))/(cell_poly_degree+1)

Closed issue Use PhysicsBase's implementation of boundary_face_values in derived classes #72

Added tests homogeneous_isotropic_turbulence_initialization_check which tests the file reader for initializing the solution within the projection loop -- this will fail if the coordinates (x,y,z) and state (s) do not match what PHiLiP expects as it is performing the loop

@jbrillon Would the test work for a DHIT on a curvilinear grid?

…s-isotropic-turbulence

jbrillon · 2023-02-24T14:24:50Z

All tests expected to pass are passing, I've attached the log file
ctest-2023-02-22.txt

jbrillon · 2023-02-24T14:27:16Z

PR to incorporate the DHIT flow test case and the added features associated with it.
Summary of features:

Initialize solution from a file

Output velocity field files at given times (for generating turbulent kinetic energy spectrum plots in post-processing using https://github.com/jbrillon/PHiLiP-Post-Processing)

Navier-Stokes can be ran for a constant viscosity if desired

LES filter width has been corrected to filter_width = pow(cell_volume, (1.0/3.0))/(cell_poly_degree+1)

Closed issue Use PhysicsBase's implementation of boundary_face_values in derived classes #72

Added tests homogeneous_isotropic_turbulence_initialization_check which tests the file reader for initializing the solution within the projection loop -- this will fail if the coordinates (x,y,z) and state (s) do not match what PHiLiP expects as it is performing the loop

@jbrillon Would the test work for a DHIT on a curvilinear grid?

@sivanadarajah I don't see why not. We would just have to interpolate/project the initial condition from the uniform grid to the curvilinear one which would have to be an added feature.

* Initial progress towards fixing the way soln_grad was computed at equidistant nodes * cleaning up code, removing output_velocity_field_at_equidistant_nodes parameter since always will be true * writing vorticity for mpi test as well

…s-isotropic-turbulence

PranshulThakur

LGTM! Thanks for addressing the comments.

Alexander and others added 30 commits February 25, 2022 16:17

ESFR Split forms. Contains all unsteady unit and integration tests. M…

b14bcc9

…akes use of operators in DG strong. Provides weight-adjusted curvilinear Mass matrices. Includes free-stream preserving metric terms.

Merge branch 'master' of https://github.com/dougshidong/PHiLiP into d…

a747833

…ougshidong-master_esfr

Merge branch 'dougshidong-master_esfr' into esfr_split_upstream_update

13a3643

Removed the accidentally pushed mesh file. Will rebase last 4 commits…

d1136cb

… into 1.

Cleaning up the accidental added line at end of some files and remove…

4064d4c

…d #if 0 #endif commented blocks.

And this file deleted last line.

ed0acc7

Fix the merge conflicts.

fb4b11b

Merge branch 'dougshidong-master' into esfr_split_upstream_update

354cc5e

Finished removing #if 0 #endif blocks, added some comments and includ…

77d5268

…ed new numerical fluxes in the numerical_flux_conservation test.

Apply suggestions from code review

a55840e

dg.cpp minor edits

Apply suggestions from code review

3730bd6

Apply suggestions from code review

e92306e

Apply suggestions from code review

a604142

Update src/parameters/all_parameters.cpp

244e270

Update with all changes requested from pull request. Only missing mer…

f378fdd

…ge conflict with ode solver base then pull request changes complete.

Merge branch 'esfr_split_upstream_update' into sum_factorization_branch

ab00c73

Merge pull request #13 from AlexanderCicchino/sum_factorization_branch

eccf61c

Sum factorization branch

Small cleanup changes before I merge upstream master in my branch.

5d110c7

Merge branch 'master' of https://github.com/dougshidong/PHiLiP into d…

27abd62

…ougshidong-master_Apr20

Merge branch 'dougshidong-master_Apr20' into esfr_split_upstream_update

1fa68c9

Made corrections to explicit ode solver with Butcher tableau c values…

c049f72

…. Updated unsteady tests. Continued to clean up and removed deprecated Burgers Rewienski lines.

Cleaned up last few comments on pull request wrt Flux reconstruction …

bd2f3e7

…operators and flags.

Removed old references to Runge-Kutta order.

6c7295b

Cleaned up re-used code in operators, and other comments from PR.

bc56b5e

Removed collection tuple from dg. Removed finite element and quadratu…

8c4ae39

…re collections from DG. Made consistent throughout the code to call operators finite element and quadrature collections from the operators collection tuple.

Fixed typos in error messages.

ed13cbb

Merge branch 'master' of https://github.com/dougshidong/PHiLiP into d…

9d28aa6

…ougshidong-master

Merge branch 'dougshidong-master' into esfr_split_upstream_update

becaad1

Created initial condition base class with interpolate and projection …

e21c7be

…capabilities for different initial condition functions. This generalizes the initial condition class.

jbrillon requested review from cpethrick and PranshulThakur February 13, 2023 21:43

jbrillon commented Feb 14, 2023

View reviewed changes

src/physics/euler.cpp Outdated Show resolved Hide resolved

fixing DHIT prm files; all tests passing that should be

c2a75d8

cpethrick reviewed Feb 16, 2023

View reviewed changes

jbrillon added 7 commits February 16, 2023 13:24

adding timer start/stop message

9e14422

addressing comment on src/dg/artificial_dissipation.h

1a5f82d

Merge remote-tracking branch 'origin/master' into decaying-homogeneou…

2ba33dd

…s-isotropic-turbulence

adding check_positive functions in euler.cpp

88a96e4

merge fix

2a4028f

correcting comment header

11c18b2

removing mpi comment for table handler

63585b0

cpethrick approved these changes Feb 16, 2023

View reviewed changes

jbrillon mentioned this pull request Feb 16, 2023

Update MPI_3D_EULER_ISMAIL_ROE_ENTROPY_CHECK for other fluxes #197

Merged

Merge remote-tracking branch 'origin/master' into decaying-homogeneou…

3b2ebf9

…s-isotropic-turbulence

PranshulThakur reviewed Feb 17, 2023

View reviewed changes

addressing PR comments

025f955

jbrillon mentioned this pull request Feb 22, 2023

Updating PHiLiP to work with the latest version of deali.II. #182

Draft

jbrillon added 3 commits February 22, 2023 14:24

Merge remote-tracking branch 'origin/master' into decaying-homogeneou…

6b003b3

…s-isotropic-turbulence

Merge remote-tracking branch 'origin/master' into decaying-homogeneou…

de1ad04

…s-isotropic-turbulence

adding DHIT test case files input files to gitignore

bcd21bf

jbrillon added 2 commits February 24, 2023 10:40

Correction to output_flow_field (#7)

a54cbe0

* Initial progress towards fixing the way soln_grad was computed at equidistant nodes * cleaning up code, removing output_velocity_field_at_equidistant_nodes parameter since always will be true * writing vorticity for mpi test as well

Merge remote-tracking branch 'origin/master' into decaying-homogeneou…

a658e7b

…s-isotropic-turbulence

PranshulThakur approved these changes Feb 24, 2023

View reviewed changes

PranshulThakur merged commit 1e45900 into dougshidong:master Feb 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Decaying homogeneous isotropic turbulence #194

Decaying homogeneous isotropic turbulence #194

jbrillon commented Feb 11, 2023 •

edited

Loading

jbrillon commented Feb 14, 2023

cpethrick left a comment

jbrillon commented Feb 16, 2023

cpethrick left a comment

PranshulThakur left a comment

sivanadarajah commented Feb 17, 2023

jbrillon commented Feb 24, 2023

jbrillon commented Feb 24, 2023

PranshulThakur left a comment

Decaying homogeneous isotropic turbulence #194

Decaying homogeneous isotropic turbulence #194

Conversation

jbrillon commented Feb 11, 2023 • edited Loading

jbrillon commented Feb 14, 2023

cpethrick left a comment

Choose a reason for hiding this comment

jbrillon commented Feb 16, 2023

cpethrick left a comment

Choose a reason for hiding this comment

PranshulThakur left a comment

Choose a reason for hiding this comment

sivanadarajah commented Feb 17, 2023

jbrillon commented Feb 24, 2023

jbrillon commented Feb 24, 2023

PranshulThakur left a comment

Choose a reason for hiding this comment

jbrillon commented Feb 11, 2023 •

edited

Loading