Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing build #257

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

acse-bn20
Copy link

I changed make to ninja. This results in 20-30% faster build time than the previous one. It successfully compiled on Narval.

Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jbrillon
Copy link
Collaborator

Since this is your first PR, post the ctest results and we'll merge it

@acse-bn20
Copy link
Author

output_ctest.log
I uploaded the local ctest results.

@cpethrick
Copy link
Collaborator

cpethrick commented May 10, 2024

There are a few tests failing which usually don't fail (at least to the best of my knowledge!). Could you confirm the behaviour of the following tests?

1D_TIME_REFINEMENT_STUDY_ADVECTION_IMPLICIT
1D_DIFFUSION_BR2_IMPLICIT_MANUFACTURED_SOLUTION
ANISOTROPIC_MESH_ADAPTATION_SSHOCK (** this one may be due to your GMSH version if I recall correctly. It may pass if you change to GMSH 4.11.1.; see discussion on the test cases channel on discord. If you have a different GMSH, it's fine to leave this failing)

I checked and these tests pass on the current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants