-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge NACA0012 optimization #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did not fix the Fedora 33 build, just keeping it commented.
Allow pointing to existing dXvdXs, or recompute it.
Note that it does not give the correct dRdX for h-adaptive tests. Please refer to issue: #48 (comment) for more details.
Allows the use of ld.gold with Ubuntu's MPI bug.
First, use cell volume to determine cell stiffness. Second, use better linear solver parameters.
Do not be so quick to accept a higher residual. Try out other direction first. And some snippets of code to test out the h-adaptivity.
At compile time, amplitude isn't necessarily seen.
Inverted cells will results in normals pointing in the same direction instead of opposite direction. In that scenario, just return a huge residual to signify that the constraints are not satisfied.
…ers. Also allows to pass a precomputed dXvdXp matrix at construction.
CFL should be negative in this scenario since we use dRdW = -R In the ODE solver, we current use M/dt - dRdW = R Therefore, the full-space basically switched sides of dRdW and R, and the mass matrix sign must be changed consequentially.
Allows working dRdX test in case of hanging nodes.
dougshidong
added a commit
that referenced
this pull request
May 19, 2022
Merge NACA0012 optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains code: