Use sqlite_ext.AutoIncrementField #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Peewee doesn't apply UNIQUE on the column, but rather on the table. + SQLite highly recommends creating indexes for foreign keys. + The DDL post-upgrade matches what's defined by the ORM, sans migration tables.
dougthor42
force-pushed
the
use-sqlite-ext-autoincrementfield
branch
from
b773a3e
to
74c4b2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the database to force use of SQLite's
AUTOINCREMENTkeyword.Note that this will create some slight overhead: https://www.sqlite.org/autoinc.html. However, I don't expect it to be a major issue given the amount of data I expect this program to handle.
This is needed because
db.insert_datapointis not returning thedatapoint_idand I can't bloody figure out why. All I know is that this solves things.