UI Overhaul #157
Merged
UI Overhaul #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougthor42
force-pushed
the
bootstrap-split-page-gh58
branch
from
66b9ec9
to
a4fe18f
Compare
+ Put the title and version in a boostrap container on the index page rather than on the layout + Rename some html elements to be more clear + Remove items from the 'data' div. No longer needed because we don't have a dedicated 'plot' page. + Update the index's JS to also send in a `metricId` to `populateTree` (if a `metricId` is given) + Remove plot.html
External Impact: 1. Do not take the user to a new page 2. Pull data from the API url /api/v1/data via AJAX rather than sending in via a template 3. Update the current URL when the user changes plots Internal Changes: + Move core of populateTree to a separate function + Use jQuery's getJSON and success/failure callbacks + Success updates the plot + failure logs an error message
+ Have `populateTree` accept a `metricId` value + add selectNodeById + Add `ready.jstree` event bind which will plot the selected `metricId` node, if it's provided.
dougthor42
force-pushed
the
bootstrap-split-page-gh58
branch
from
a4fe18f
to
792983a
Compare
+ Plot responsive to window size. + list of metrics almost the same size as the plot window + Allow the graph to take up full width.
+ separate out test_plot_with_data to '_by_name' and '_by_id' + Remove skipped test - replaced by new ones. (which are also skipped... but now I have a better reason for it!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR overhauls the UI and fixes #58.
api_plotblueprintGET /api/v1/plot/<metric_id>route which returns data ready to be consumed by PlotlyGET /api/v1/data/<metric_name>, but acceptsmetric_idinstead.TODO:
/plot/<metric_name>route so that it provides a direct link to the plotindex.htmlandplot.htmlintolayout.html. This was a mistake -layoutshould still be separate fromindex.plot/<metric_id>anddata/<metric_name>Preview: