Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkDenyHostの$this->serversを$this->serverに修正 #29

Merged
merged 1 commit into from Jan 12, 2016
Merged

checkDenyHostの$this->serversを$this->serverに修正 #29

merged 1 commit into from Jan 12, 2016

Conversation

khsk
Copy link
Contributor

@khsk khsk commented Jan 12, 2016

deny_hostconfigを設定し、checkDenyHostを呼び出すと以下のエラーがでます。

PHP Notice:  Undefined property: TransmitMail::$servers in /TransmitMail-master/lib/TransmitMail.php on line 352
PHP Notice:  Undefined property: TransmitMail::$servers in /TransmitMail-master/lib/TransmitMail.php on line 353

原因は、
getRequestで$this->serverに代入しているのに
checkDenyHostでは$this->serversを参照している
ことだと思われます。

$this->servers -> $this->server
@dounokouno
Copy link
Owner

PR ありがとうございます!確認します!

dounokouno added a commit that referenced this pull request Jan 12, 2016
checkDenyHostの$this->serversを$this->serverに修正
@dounokouno dounokouno merged commit 303b176 into dounokouno:master Jan 12, 2016
@dounokouno
Copy link
Owner

ご指摘の通りでしたので、マージさせていただきました。

(また、別の箇所( feede0a )にもコードの間違いがあり、アクセス拒否設定が正しく動作しないことを確認しましたので、マージ後に修正をしました。)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants