Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
sysulq committed Oct 21, 2022
1 parent e447ba4 commit c07470b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions pkg/registry/etcdv3/registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (

"github.com/douyu/jupiter/pkg"
"github.com/douyu/jupiter/pkg/client/etcdv3"
"github.com/douyu/jupiter/pkg/conf"
"github.com/douyu/jupiter/pkg/core/constant"
"github.com/douyu/jupiter/pkg/core/ecode"
"github.com/douyu/jupiter/pkg/registry"
Expand Down Expand Up @@ -98,7 +97,7 @@ func (reg *etcdv3Registry) UnregisterService(ctx context.Context, info *server.S

// ListServices list service registered in registry with name `name`
func (reg *etcdv3Registry) ListServices(ctx context.Context, name string, scheme string) (services []*server.ServiceInfo, err error) {
target := fmt.Sprintf(servicePrefix, scheme, name, "v1", conf.GetString("app.mode"))
target := fmt.Sprintf(servicePrefix, scheme, name, "v1", pkg.AppMode())
getResp, getErr := reg.client.Get(ctx, target, clientv3.WithPrefix())
if getErr != nil {
reg.logger.Error(ecode.MsgWatchRequestErr, xlog.FieldErrKind(ecode.ErrKindRequestErr), xlog.FieldErr(getErr), xlog.FieldAddr(target))
Expand Down Expand Up @@ -277,7 +276,7 @@ func (reg *etcdv3Registry) doKeepalive(ctx context.Context) {
kac, err := reg.client.KeepAlive(ctx, reg.leaseID)
if err != nil {
reg.leaseID = 0
reg.logger.Error("reg.lease.KeepAlive failed", xlog.FieldErrKind(ecode.ErrKindRegisterErr), xlog.FieldErr(err))
reg.logger.Error("reg.client.KeepAlive failed", xlog.FieldErrKind(ecode.ErrKindRegisterErr), xlog.FieldErr(err))
}

for {
Expand Down Expand Up @@ -318,7 +317,7 @@ func (reg *etcdv3Registry) doKeepalive(ctx context.Context) {
// when error or timeout happens, just exit the goroutine
kac, err = reg.client.KeepAlive(cancelCtx, reg.leaseID)
if err != nil {
reg.logger.Error("reg.lease.KeepAlive failed", xlog.FieldErrKind(ecode.ErrKindRegisterErr), xlog.FieldErr(err))
reg.logger.Error("reg.client.KeepAlive failed", xlog.FieldErrKind(ecode.ErrKindRegisterErr), xlog.FieldErr(err))
errChan <- err
return
}
Expand All @@ -331,6 +330,7 @@ func (reg *etcdv3Registry) doKeepalive(ctx context.Context) {
case <-errChan:
// when error happens
// we just retry again

continue
case <-time.After(3 * time.Second):
// when timeout happens
Expand Down

0 comments on commit c07470b

Please sign in to comment.