Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace defers with hooks #367

Merged
merged 3 commits into from
Aug 24, 2022
Merged

feat: replace defers with hooks #367

merged 3 commits into from
Aug 24, 2022

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Aug 23, 2022

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #367 (77e680c) into master (4d33ced) will increase coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
+ Coverage   36.45%   36.48%   +0.03%     
==========================================
  Files          82       81       -1     
  Lines        5262     5257       -5     
==========================================
  Hits         1918     1918              
+ Misses       3226     3221       -5     
  Partials      118      118              
Impacted Files Coverage Δ
pkg/xlog/log.go 72.05% <0.00%> (+1.04%) ⬆️
pkg/client/rocketmq/consumer.go 40.81% <100.00%> (+0.51%) ⬆️
pkg/hooks/hooks.go 100.00% <100.00%> (ø)
pkg/store/gorm/init.go 42.30% <0.00%> (+11.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sysulq sysulq merged commit e09be57 into master Aug 24, 2022
@sysulq sysulq deleted the feat/remove-defers branch August 24, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants