feat: use freecache #416
Merged
feat: use freecache #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
可以补下单测 |
|
可以放在pkg/cache/freecache，方便后面增加其他cache实现 |
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
- Coverage 40.29% 39.97% -0.33%
==========================================
Files 84 84
Lines 5611 5611
==========================================
- Hits 2261 2243 -18
- Misses 3192 3211 +19
+ Partials 158 157 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sysulq
approved these changes
Sep 23, 2022
pkg/cache/localcache.go
Outdated
| // metric上报 | ||
| if !l.req.DisableMetric { | ||
| defer func() { | ||
| prome.LocalCacheHandleHistogram.WithLabelValues(prome.TypeLocalCache, l.req.Name, "EntryCount").Observe(float64(l.cache.EntryCount())) |
pkg/cache/localcache.go
Outdated
| // metric上报 | ||
| if !l.req.DisableMetric { | ||
| defer func() { | ||
| prome.LocalCacheHandleHistogram.WithLabelValues(prome.TypeLocalCache, l.req.Name, "MissCount").Observe(float64(l.cache.MissCount())) |
pkg/cache/cache.go
Outdated
| }() | ||
|
|
||
| func() { | ||
| defer func() { |
pkg/cache/localcache.go
Outdated
| Cache | ||
| } | ||
|
|
||
| type LocalCacheReq struct { |
pkg/cache/localcache.go
Outdated
| xlog.Jupiter().Panic("cache NewLocalCache expire err", zap.Any("req", req)) | ||
| } | ||
| if len(req.Name) == 0 { | ||
| req.Name = fmt.Sprintf("cache-%d", time.Now().UnixNano()) |
pkg/cache/xerr/err.go
Outdated
| @@ -0,0 +1,36 @@ | |||
| package xerr | |||
|
|
|||
pkg/cache/xfreecache/localcache.go
Outdated
| data, err = l.cache.Get([]byte(key)) | ||
| // metric report | ||
| if !l.req.DisableMetric { | ||
| prome.CacheHandleGauge.WithLabelValues(prome.TypeLocalCache, l.req.Name, "HitRate").Set(l.cache.HitRate()) |
There was a problem hiding this comment.
看上去这个每次都会遍历几百个segments，感觉可能会对效率有影响
如果自己来统计这个是不是会更高效呢？可以考虑写个benchmark看看
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews