Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve tracing with otel #451

Merged
merged 16 commits into from
Sep 30, 2022
Merged

feat: improve tracing with otel #451

merged 16 commits into from
Sep 30, 2022

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Sep 30, 2022

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #451 (5359357) into master (2f89204) will increase coverage by 0.03%.
The diff coverage is 35.68%.

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
+ Coverage   40.40%   40.44%   +0.03%     
==========================================
  Files          88       89       +1     
  Lines        5717     5798      +81     
==========================================
+ Hits         2310     2345      +35     
- Misses       3240     3281      +41     
- Partials      167      172       +5     
Impacted Files Coverage Δ
pkg/client/grpc/interceptor.go 0.00% <0.00%> (ø)
pkg/server/xgrpc/config.go 26.86% <0.00%> (ø)
pkg/server/xgrpc/interceptor.go 1.04% <0.00%> (-0.03%) ⬇️
pkg/client/rocketmq/consumer.go 37.66% <13.33%> (-2.82%) ⬇️
pkg/client/rocketmq/log.go 38.88% <38.88%> (ø)
pkg/client/resty/resty.go 88.70% <84.61%> (-0.18%) ⬇️
pkg/application/application.go 75.42% <100.00%> (ø)
pkg/client/rocketmq/init.go 6.77% <100.00%> (+4.99%) ⬆️
pkg/client/rocketmq/interceptor.go 56.70% <100.00%> (+0.53%) ⬆️
pkg/client/rocketmq/option.go 71.76% <100.00%> (+0.68%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sysulq sysulq merged commit 6647ca1 into master Sep 30, 2022
@sysulq sysulq deleted the feat/otel branch October 13, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants