feat: unregister before stop #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #462 +/- ##
==========================================
- Coverage 41.02% 40.99% -0.04%
==========================================
Files 89 89
Lines 5740 5750 +10
==========================================
+ Hits 2355 2357 +2
- Misses 3206 3213 +7
- Partials 179 180 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
papa-hexuan
changed the title
papa-hexuan
force-pushed
the
feat/unregister
branch
from
63736db
to
529794b
Compare
sysulq
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
unregister before stop
Does this pull request fix one issue?
Describe how you did it
unregistered before stop and graceful stop
Describe how to verify it
Special notes for reviews