Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve registry implementation #482

Merged
merged 3 commits into from
Oct 19, 2022
Merged

feat: improve registry implementation #482

merged 3 commits into from
Oct 19, 2022

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Oct 19, 2022

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Merging #482 (a7eff59) into master (3f036d0) will increase coverage by 0.07%.
The diff coverage is 52.63%.

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   40.80%   40.87%   +0.07%     
==========================================
  Files          89       89              
  Lines        5747     5759      +12     
==========================================
+ Hits         2345     2354       +9     
- Misses       3222     3225       +3     
  Partials      180      180              
Impacted Files Coverage Δ
pkg/client/grpc/resolver/resolver.go 0.00% <0.00%> (ø)
pkg/util/xgo/init.go 9.67% <0.00%> (-0.33%) ⬇️
pkg/client/grpc/client.go 84.61% <100.00%> (+3.97%) ⬆️
pkg/client/grpc/config.go 25.64% <100.00%> (+0.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sysulq sysulq merged commit cf8f877 into master Oct 19, 2022
@sysulq sysulq deleted the feat/registry branch October 28, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants