Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make registry unit test works #498

Merged
merged 6 commits into from
Oct 21, 2022
Merged

fix: make registry unit test works #498

merged 6 commits into from
Oct 21, 2022

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Oct 21, 2022

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #498 (0a8a89b) into master (6e00bca) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
+ Coverage   41.16%   41.26%   +0.10%     
==========================================
  Files          90       90              
  Lines        5770     5770              
==========================================
+ Hits         2375     2381       +6     
+ Misses       3216     3211       -5     
+ Partials      179      178       -1     
Impacted Files Coverage Δ
pkg/client/rocketmq/init.go 100.00% <0.00%> (+60.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sysulq sysulq changed the title fix: golangci-lint error fix: golangci-lint error and registry unit test Oct 21, 2022
@sysulq sysulq changed the title fix: golangci-lint error and registry unit test fix: make registry unit test works Oct 21, 2022
@sysulq sysulq merged commit 388bc3c into master Oct 21, 2022
@sysulq sysulq deleted the fix/lint-error branch October 25, 2022 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants