feat: add support for go-redis/v8 #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papa-hexuan
force-pushed
the
feat-redigo
branch
from
54cc234
to
b90b48d
Compare
|
sum(client_stats_gauge{job="appname" ,type="redis",index="idle_conns"})by(name) |
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
==========================================
+ Coverage 46.56% 50.82% +4.25%
==========================================
Files 105 106 +1
Lines 6859 6808 -51
==========================================
+ Hits 3194 3460 +266
+ Misses 3415 3092 -323
- Partials 250 256 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sysulq
changed the title
|
可以直接把redis替换掉 @papa-hexuan |
added 2 commits
October 25, 2022 00:01
sysulq
previously approved these changes
Oct 26, 2022
pkg/client/redisgo/init.go
Outdated
| "time" | ||
|
|
||
| prome "github.com/douyu/jupiter/pkg/core/metric" | ||
|
|
|
|
||
| "github.com/douyu/jupiter/pkg/server/governor" | ||
| jsoniter "github.com/json-iterator/go" | ||
|
|
go.mod
Outdated
| @@ -9,14 +9,13 @@ require ( | |||
| github.com/alicebob/miniredis/v2 v2.23.0 | |||
| github.com/apache/rocketmq-client-go/v2 v2.1.1 | |||
| github.com/codegangsta/inject v0.0.0-20150114235600-33e0aa1cb7c0 | |||
| github.com/coocood/freecache v1.2.2 | |||
go.mod
Outdated
| gorm.io/gorm v1.24.0 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/coocood/freecache v1.2.2 |
pkg/client/redisgo/client.go
Outdated
| } | ||
|
|
||
| // Singleton 单例模式 | ||
| func (config *Config) Singleton() *Client { |
pkg/client/redisgo/client.go
Outdated
| } | ||
|
|
||
| // Build .. | ||
| func (config *Config) Build() *Client { |
pkg/client/redisgo/client_test.go
Outdated
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| var addr = "10.1.104.19:6740" |
There was a problem hiding this comment.
测试redis用localhost，github上有跑一个本地的redis服务
pkg/client/redisgo/config_test.go
Outdated
| dialTimeout="2s" | ||
| readTimeout="5s" | ||
| idleTimeout="60s" | ||
| username="" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews