Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve log mod name #517

Merged
merged 7 commits into from
Oct 26, 2022
Merged

chore: improve log mod name #517

merged 7 commits into from
Oct 26, 2022

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Oct 26, 2022

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #517 (8b30a22) into master (4b199ff) will increase coverage by 0.05%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
+ Coverage   50.77%   50.82%   +0.05%     
==========================================
  Files         106      105       -1     
  Lines        6808     6754      -54     
==========================================
- Hits         3457     3433      -24     
+ Misses       3097     3067      -30     
  Partials      254      254              
Impacted Files Coverage Δ
pkg/client/rocketmq/init.go 25.00% <0.00%> (-15.00%) ⬇️
pkg/registry/etcdv3/config.go 0.00% <0.00%> (ø)
pkg/registry/etcdv3/registry.go 70.34% <33.33%> (-1.04%) ⬇️
pkg/client/grpc/config.go 77.77% <100.00%> (ø)
pkg/client/redisgo/config.go 70.37% <100.00%> (ø)
pkg/client/resty/resty.go 88.70% <100.00%> (ø)
pkg/core/application/application.go 72.46% <100.00%> (+0.22%) ⬆️
pkg/server/xgrpc/config.go 26.86% <100.00%> (ø)
pkg/core/rocketmq/log.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sysulq sysulq merged commit f0f1f7b into master Oct 26, 2022
@sysulq sysulq deleted the feat/mod branch October 28, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants