Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more linter #669

Merged
merged 13 commits into from
Feb 2, 2023
Merged

feat: add more linter #669

merged 13 commits into from
Feb 2, 2023

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Jan 17, 2023

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@sysulq sysulq temporarily deployed to tablestore-live January 17, 2023 06:42 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023

Codecov Report

Merging #669 (d68c92c) into master (48ff65c) will increase coverage by 0.02%.
The diff coverage is 57.89%.

@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
+ Coverage   53.25%   53.28%   +0.02%     
==========================================
  Files         190      190              
  Lines       10329    10386      +57     
==========================================
+ Hits         5501     5534      +33     
- Misses       4406     4430      +24     
  Partials      422      422              
Impacted Files Coverage Δ
pkg/client/rocketmq/pull_consumer.go 56.83% <ø> (ø)
pkg/conf/datasource.go 10.52% <ø> (ø)
pkg/core/cmd/cmd_new.go 34.95% <0.00%> (ø)
pkg/core/constant/service.go 50.00% <ø> (ø)
pkg/core/signals/signals.go 100.00% <ø> (ø)
pkg/env.go 63.04% <0.00%> (ø)
pkg/executor/executor.go 18.18% <ø> (ø)
pkg/executor/xxl/executor.go 39.82% <ø> (ø)
pkg/executor/xxl/list.go 100.00% <ø> (ø)
pkg/executor/xxl/util.go 100.00% <ø> (ø)
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sysulq sysulq temporarily deployed to tablestore-live January 17, 2023 06:51 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live January 17, 2023 06:57 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live January 17, 2023 06:58 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live January 17, 2023 07:09 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live January 17, 2023 07:23 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live January 17, 2023 07:30 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live January 17, 2023 07:33 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live January 17, 2023 07:45 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live January 17, 2023 07:55 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live January 17, 2023 08:02 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live February 1, 2023 08:10 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live February 1, 2023 08:11 — with GitHub Actions Inactive
@sysulq sysulq merged commit 3eef958 into master Feb 2, 2023
@sysulq sysulq deleted the feat/lint branch February 17, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants