Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not generate xerror when no enum found #704

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Feb 6, 2023

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@sysulq sysulq temporarily deployed to tablestore-live February 6, 2023 08:27 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live February 6, 2023 09:07 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #704 (de61e75) into master (b05007c) will decrease coverage by 18.44%.
The diff coverage is 47.61%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           master     #704       +/-   ##
===========================================
- Coverage   53.40%   34.97%   -18.44%     
===========================================
  Files         189      154       -35     
  Lines       10478     7960     -2518     
===========================================
- Hits         5596     2784     -2812     
- Misses       4461     4946      +485     
+ Partials      421      230      -191     
Impacted Files Coverage Δ
proto/error/v1/error.pb.go 86.95% <ø> (ø)
proto/helloworld/v1/helloworld.pb.go 20.00% <ø> (ø)
proto/helloworld/v1/error.pb.go 47.61% <47.61%> (ø)
pkg/util/xerror/code_msg.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/core/sentinel/sentinel_circuitbreaker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/util/xgo/serial.go 0.00% <0.00%> (-96.78%) ⬇️
pkg/util/xcast/cast.go 0.00% <0.00%> (-91.67%) ⬇️
pkg/util/xgo/parallel.go 0.00% <0.00%> (-86.80%) ⬇️
pkg/util/xretry/retry.go 15.38% <0.00%> (-84.62%) ⬇️
pkg/util/xstring/conv.go 0.00% <0.00%> (-84.22%) ⬇️
... and 81 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sysulq sysulq merged commit 41319a9 into master Feb 6, 2023
@sysulq sysulq deleted the fix/xerror-patch1 branch February 17, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants