Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get register address from listener #739

Merged
merged 3 commits into from
Mar 7, 2023
Merged

feat: get register address from listener #739

merged 3 commits into from
Mar 7, 2023

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Feb 21, 2023

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@sysulq sysulq temporarily deployed to tablestore-live February 21, 2023 09:17 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Merging #739 (9e17017) into master (f728f7d) will decrease coverage by 0.43%.
The diff coverage is 46.15%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
- Coverage   53.70%   53.27%   -0.43%     
==========================================
  Files         196      199       +3     
  Lines       10835    11016     +181     
==========================================
+ Hits         5819     5869      +50     
- Misses       4570     4699     +129     
- Partials      446      448       +2     
Impacted Files Coverage Δ
pkg/server/governor/server.go 63.63% <0.00%> (-12.04%) ⬇️
pkg/server/xecho/config.go 58.66% <ø> (+2.30%) ⬆️
pkg/server/xecho/server.go 59.77% <0.00%> (+2.62%) ⬆️
pkg/server/xfasthttp/server.go 62.65% <0.00%> (+1.00%) ⬆️
pkg/server/xgin/server.go 69.64% <0.00%> (-3.83%) ⬇️
pkg/util/xnet/address.go 50.00% <50.00%> (ø)
pkg/server/init.go 64.28% <100.00%> (+14.28%) ⬆️
pkg/server/server.go 95.52% <100.00%> (-4.48%) ⬇️
pkg/server/xgrpc/server.go 76.03% <100.00%> (+1.95%) ⬆️
pkg/util/xnet/ip.go 0.00% <0.00%> (-15.22%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sysulq sysulq temporarily deployed to tablestore-live February 21, 2023 09:28 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live March 1, 2023 04:20 — with GitHub Actions Inactive
@sysulq sysulq merged commit dbfe7d6 into master Mar 7, 2023
@sysulq sysulq deleted the feat/listener branch March 31, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants