lib-smtp: client: Fix memory issue caused when reconnecting.

dovecot · Feb 12, 2019 · 025f752 · 025f752
1 parent 2687917
commit 025f752
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/lib-smtp/smtp-client-connection.c b/src/lib-smtp/smtp-client-connection.c
@@ -1737,7 +1737,7 @@ smtp_client_connection_create(struct smtp_client *client,
 	conn->host = p_strdup(conn->pool, host);
 	conn->port = port;
 	conn->ssl_mode = ssl_mode;
-	conn->conn.name = p_strdup_printf(conn->pool, "%s:%u", host, port);
+	conn->conn.name = i_strdup_printf("%s:%u", host, port);
 
 	conn->set = client->set;
 	if (set != NULL) {

diff --git a/src/lib/connection.c b/src/lib/connection.c
@@ -229,7 +229,8 @@ void connection_init(struct connection_list *list,
 	conn->ioloop = current_ioloop;
 	conn->fd_in = -1;
 	conn->fd_out = -1;
-	conn->name = NULL;
+
+	i_free(conn->name);
 
 	if (conn->event == NULL)
 		conn->event = event_create(conn->event_parent);