lib-smtp: smtp-server-reply - Add smtp_server_reply_is_success() and …

…use it.
dovecot · Mar 2, 2019 · 03ba35d · 03ba35d
1 parent 4fc917e
commit 03ba35d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/lib-smtp/smtp-server-command.c b/src/lib-smtp/smtp-server-command.c
@@ -613,8 +613,7 @@ bool smtp_server_command_replied_success(struct smtp_server_command *cmd)
 			array_idx(&cmd->replies, i);
 		if (!reply->submitted)
 			return FALSE;
-		i_assert(reply->content != NULL);
-		if (reply->content->status / 100 == 2)
+		if (smtp_server_reply_is_success(reply))
 			success = TRUE;
 	}
 

diff --git a/src/lib-smtp/smtp-server-reply.c b/src/lib-smtp/smtp-server-reply.c
@@ -488,6 +488,12 @@ int smtp_server_reply_send(struct smtp_server_reply *reply)
 	return ret;
 }
 
+bool smtp_server_reply_is_success(const struct smtp_server_reply *reply)
+{
+	i_assert(reply->content != NULL);
+	return (reply->content->status / 100 == 2);
+}
+
 /*
  * EHLO reply
  */

diff --git a/src/lib-smtp/smtp-server.h b/src/lib-smtp/smtp-server.h
@@ -650,6 +650,8 @@ void smtp_server_reply_early(struct smtp_server_cmd_ctx *_cmd,
 /* Reply the command with a 221 bye message */
 void smtp_server_reply_quit(struct smtp_server_cmd_ctx *_cmd);
 
+bool smtp_server_reply_is_success(const struct smtp_server_reply *reply);
+
 /* EHLO */
 
 struct smtp_server_reply *