dbox: mailbox_update() shouldn't reset pop3-uidl header.

This broke reading migrated POP3 UIDLs.
dovecot · Sep 22, 2016 · 051db9c · 051db9c
1 parent 566c9a2
commit 051db9c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/lib-storage/index/dbox-multi/mdbox-storage.c b/src/lib-storage/index/dbox-multi/mdbox-storage.c
@@ -308,8 +308,11 @@ mdbox_write_index_header(struct mailbox *box,
 	}
 	mail_index_view_close(&view);
 
-	if (box->inbox_user)
+	if (box->inbox_user && box->creating) {
+		/* initialize pop3-uidl header when creating mailbox
+		   (not on mailbox_update()) */
 		index_pop3_uidl_set_max_uid(box, trans, 0);
+	}
 
 	mdbox_update_header(mbox, trans, update);
 	if (new_trans != NULL) {

diff --git a/src/lib-storage/index/dbox-single/sdbox-storage.c b/src/lib-storage/index/dbox-single/sdbox-storage.c
@@ -263,8 +263,11 @@ int sdbox_mailbox_create_indexes(struct mailbox *box,
 						 update->min_highest_modseq);
 	}
 
-	if (box->inbox_user)
+	if (box->inbox_user && box->creating) {
+		/* initialize pop3-uidl header when creating mailbox
+		   (not on mailbox_update()) */
 		index_pop3_uidl_set_max_uid(box, trans, 0);
+	}
 
 	sdbox_update_header(mbox, trans, update);
 	if (new_trans != NULL) {