global: start relying on fs_iter_deinit(NULL) being a no-op

dovecot · May 26, 2018 · 0a4cf11 · 0a4cf11
1 parent 0d5ef33
commit 0a4cf11
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/lib-dict-extra/dict-fs.c b/src/lib-dict-extra/dict-fs.c
@@ -195,10 +195,9 @@ static int fs_dict_iterate_deinit(struct dict_iterate_context *ctx,
 	struct fs_dict *dict = (struct fs_dict *)ctx->dict;
 	int ret;
 
-	if (iter->fs_iter != NULL) {
-		if (fs_iter_deinit(&iter->fs_iter) < 0 && iter->error == NULL)
-			iter->error = i_strdup(fs_last_error(dict->fs));
-	}
+	if (fs_iter_deinit(&iter->fs_iter) < 0 && iter->error == NULL)
+		iter->error = i_strdup(fs_last_error(dict->fs));
+
 	ret = iter->error != NULL ? -1 : 0;
 	*error_r = t_strdup(iter->error);