Skip to content

Commit

Permalink
imapc: %zu isn't standard, use PRIuSIZE_T instead.
Browse files Browse the repository at this point in the history
  • Loading branch information
@sirainen
sirainen committed Nov 18, 2016
1 parent a5b64f1 commit 2f26f75
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/lib-storage/index/imapc/imapc-storage.c
View file
Expand Up @@ -353,7 +353,7 @@ imapc_storage_create(struct mail_storage *_storage,
/* serialize all the settings */
_storage->unique_root_dir = p_strdup_printf(_storage->pool,
"%s%s://(%s|%s):%s@%s:%u/%s mechs:%s features:%s "
"rawlog:%s cmd_timeout:%u maxidle:%u maxline:%zu "
"rawlog:%s cmd_timeout:%u maxidle:%u maxline:%"PRIuSIZE_T"u "
"pop3delflg:%s root_dir:%s",
storage->set->imapc_ssl,
storage->set->imapc_ssl_verify ? "(verify)" : "",
Expand Down

2 comments on commit 2f26f75

@richfelker
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The claim in the commit message is wrong and in fact the opposite is true. The z modifier has been standard since C99; the C11 citation for it is 7.21.6.1¶7. PRIuSIZE_T has never been part of any standard (see 7.8.1 for its absence). It looks like this has been fixed in 0360044, but without any documentation of the reason, so I'm putting it here in a comment.

@sirainen
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm not sure why I originally thought it wasn't standard.

Please sign in to comment.