lib: If DEBUG is enabled, use a pointer type for data_stack_frame_t

This allows telling static analyzers to treat t_push() and t_pop() similarly to malloc()/free() and check for leaks.
dovecot · Sep 2, 2016 · 32c3ba3 · 32c3ba3
1 parent 3c5ee51
commit 32c3ba3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/lib/data-stack.c b/src/lib/data-stack.c
@@ -67,6 +67,12 @@ struct stack_frame_block {
 #endif
 };
 
+#ifdef DEBUG
+struct data_stack_frame {
+	int dummy;
+};
+#endif
+
 data_stack_frame_t data_stack_frame = 0;
 
 static bool data_stack_initialized = FALSE;
@@ -571,7 +577,7 @@ void data_stack_init(void)
 		return;
 	}
 	data_stack_initialized = TRUE;
-	data_stack_frame = 1;
+	data_stack_frame = (data_stack_frame_t)1;
 
 	outofmem_area.block.size = outofmem_area.block.left =
 		sizeof(outofmem_area) - sizeof(outofmem_area.block);

diff --git a/src/lib/data-stack.h b/src/lib/data-stack.h
@@ -31,7 +31,11 @@
       overflows.
 */
 
+#ifndef DEBUG
 typedef unsigned int data_stack_frame_t;
+#else
+typedef struct data_stack_frame *data_stack_frame_t;
+#endif
 
 extern data_stack_frame_t data_stack_frame;