doveadm director: Invalid parameters cause doveadm to fail silently.

doveadm_cmd_context.cmd doesn't point directly to doveadm_cmd_director.
dovecot · Oct 25, 2016 · 3d76809 · 3d76809
1 parent a9ade10
commit 3d76809
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/doveadm/doveadm-director.c b/src/doveadm/doveadm-director.c
@@ -992,9 +992,10 @@ static void director_cmd_help(const struct doveadm_cmd_ver2 *cmd)
 	unsigned int i;
 
 	for (i = 0; i < N_ELEMENTS(doveadm_cmd_director); i++) {
-		if (doveadm_cmd_director+i == cmd)
+		if (doveadm_cmd_director[i].cmd == cmd->cmd)
 			help_ver2(&doveadm_cmd_director[i]);
 	}
+	i_unreached();
 }
 
 void doveadm_register_director_commands(void)