Skip to content

Commit

Permalink
login-common,lib-ssl-iostream: Use SSL_CTX_set_ecdh_auto
Browse files Browse the repository at this point in the history
This macro is same for 1.0.2 and 1.1.0 and libressl.
  • Loading branch information
cmouse authored and sirainen committed Feb 19, 2018
1 parent aa4adc0 commit 3ef6a75
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions src/lib-ssl-iostream/iostream-openssl-context.c
Expand Up @@ -378,7 +378,7 @@ ssl_iostream_context_set(struct ssl_iostream_context *ctx,
return 0;
}

#if defined(HAVE_ECDH) && !defined(SSL_CTRL_SET_ECDH_AUTO)
#if defined(HAVE_ECDH) && !defined(SSL_CTX_set_ecdh_auto)
static int
ssl_proxy_ctx_get_pkey_ec_curve_name(const struct ssl_iostream_settings *set,
int *nid_r, const char **error_r)
Expand Down Expand Up @@ -412,7 +412,7 @@ ssl_proxy_ctx_set_crypto_params(SSL_CTX *ssl_ctx,
const struct ssl_iostream_settings *set ATTR_UNUSED,
const char **error_r ATTR_UNUSED)
{
#if defined(HAVE_ECDH) && !defined(SSL_CTRL_SET_ECDH_AUTO)
#if defined(HAVE_ECDH) && !defined(SSL_CTX_set_ecdh_auto)
EC_KEY *ecdh;
int nid;
const char *curve_name;
Expand All @@ -425,7 +425,7 @@ ssl_proxy_ctx_set_crypto_params(SSL_CTX *ssl_ctx,
used instead of ECDHE, do not reuse the same ECDH key pair for
different sessions. This option improves forward secrecy. */
SSL_CTX_set_options(ssl_ctx, SSL_OP_SINGLE_ECDH_USE);
#ifdef SSL_CTRL_SET_ECDH_AUTO
#ifdef SSL_CTX_set_ecdh_auto
/* OpenSSL >= 1.0.2 automatically handles ECDH temporary key parameter
selection. */
if (!SSL_CTX_set_ecdh_auto(ssl_ctx, 1)) {
Expand Down
8 changes: 4 additions & 4 deletions src/login-common/ssl-proxy-openssl.c
Expand Up @@ -134,7 +134,7 @@ static void ssl_server_context_deinit(struct ssl_server_context **_ctx);

static void ssl_proxy_ctx_set_crypto_params(SSL_CTX *ssl_ctx,
const struct master_service_ssl_settings *set);
#if defined(HAVE_ECDH) && !defined(SSL_CTRL_SET_ECDH_AUTO)
#if defined(HAVE_ECDH) && !defined(SSL_CTX_set_ecdh_auto)
static int ssl_proxy_ctx_get_pkey_ec_curve_name(const struct master_service_ssl_settings *set);
#endif

Expand Down Expand Up @@ -1051,7 +1051,7 @@ static void
ssl_proxy_ctx_set_crypto_params(SSL_CTX *ssl_ctx,
const struct master_service_ssl_settings *set ATTR_UNUSED)
{
#if defined(HAVE_ECDH) && !defined(SSL_CTRL_SET_ECDH_AUTO)
#if defined(HAVE_ECDH) && !defined(SSL_CTX_set_ecdh_auto)
EC_KEY *ecdh;
int nid;
const char *curve_name;
Expand All @@ -1064,7 +1064,7 @@ ssl_proxy_ctx_set_crypto_params(SSL_CTX *ssl_ctx,
used instead of ECDHE, do not reuse the same ECDH key pair for
different sessions. This option improves forward secrecy. */
SSL_CTX_set_options(ssl_ctx, SSL_OP_SINGLE_ECDH_USE);
#ifdef SSL_CTRL_SET_ECDH_AUTO
#ifdef SSL_CTX_set_ecdh_auto
/* OpenSSL >= 1.0.2 automatically handles ECDH temporary key parameter
selection. */
SSL_CTX_set_ecdh_auto(ssl_ctx, 1);
Expand Down Expand Up @@ -1157,7 +1157,7 @@ ssl_proxy_ctx_use_key(SSL_CTX *ctx,
}
}

#if defined(HAVE_ECDH) && !defined(SSL_CTRL_SET_ECDH_AUTO)
#if defined(HAVE_ECDH) && !defined(SSL_CTX_set_ecdh_auto)
static int
ssl_proxy_ctx_get_pkey_ec_curve_name(const struct master_service_ssl_settings *set)
{
Expand Down

0 comments on commit 3ef6a75

Please sign in to comment.