auth: Ensure username can't be left unset in APOP

Makes static analysers happy
dovecot · Aug 17, 2016 · 45e3aa0 · 45e3aa0
1 parent d18e554
commit 45e3aa0
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/auth/mech-apop.c b/src/auth/mech-apop.c
@@ -101,6 +101,12 @@ mech_apop_auth_initial(struct auth_request *auth_request,
 		username = ++tmp;
 		while (tmp != end && *tmp != '\0')
 			tmp++;
+	} else {
+		/* should never happen */
+		auth_request_log_info(auth_request, AUTH_SUBSYS_MECH,
+			"malformed data");
+		auth_request_fail(auth_request);
+		return;
 	}
 
 	if (tmp + 1 + 16 != end) {