submission-login: Fix NULL dereference occurring at an invalid reply …

…from the backend server. Problem found by Coverity.
dovecot · Dec 12, 2017 · 4a1af46 · 4a1af46
1 parent 836ed7e
commit 4a1af46
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/submission-login/submission-proxy.c b/src/submission-login/submission-proxy.c
@@ -233,6 +233,8 @@ int submission_proxy_parse_line(struct client *client, const char *line)
 		str_parse_uint(line, &status, &text) < 0 ||
 		status < 200 || status >= 560) {
 		invalid_line = TRUE;
+	} else {
+		text++;
 	}
 	if (subm_client->proxy_reply_status != 0 &&
 		subm_client->proxy_reply_status != status) {
@@ -249,7 +251,6 @@ int submission_proxy_parse_line(struct client *client, const char *line)
 	} else {
 		subm_client->proxy_reply_status = status;
 	}
-	text++;
 
 	if ((subm_client->proxy_capability &
 		SMTP_CAPABILITY_ENHANCEDSTATUSCODES) != 0)