Skip to content

Commit

Permalink
doveadm mailbox metadata list: Fix listing all metadata.
Browse files Browse the repository at this point in the history
It was listing only private attributes, because key_type=0 happens to be
MAIL_ATTRIBUTE_TYPE_PRIVATE and key was never NULL.
  • Loading branch information
sirainen committed Feb 10, 2017
1 parent c1ab825 commit 4a48987
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/doveadm/doveadm-mail-mailbox-metadata.c
Expand Up @@ -265,13 +265,13 @@ cmd_mailbox_metadata_list_run(struct doveadm_mail_cmd_context *_ctx,
if (ret != 0)
return ret;

if (ctx->key == NULL || ctx->key_type == MAIL_ATTRIBUTE_TYPE_PRIVATE) {
if (ctx->key[0] == '\0' || ctx->key_type == MAIL_ATTRIBUTE_TYPE_PRIVATE) {
if (cmd_mailbox_metadata_list_run_iter(ctx, box, MAIL_ATTRIBUTE_TYPE_PRIVATE) < 0) {
doveadm_mail_failed_mailbox(_ctx, box);
ret = -1;
}
}
if (ctx->key == NULL || ctx->key_type == MAIL_ATTRIBUTE_TYPE_SHARED) {
if (ctx->key[0] == '\0' || ctx->key_type == MAIL_ATTRIBUTE_TYPE_SHARED) {
if (cmd_mailbox_metadata_list_run_iter(ctx, box, MAIL_ATTRIBUTE_TYPE_SHARED) < 0) {
doveadm_mail_failed_mailbox(_ctx, box);
ret = -1;
Expand Down

0 comments on commit 4a48987

Please sign in to comment.