Skip to content

Commit

Permalink
m4/dovecot.m4: rename valgrind output file to hide it from certain tests
Browse files Browse the repository at this point in the history
Some lib-http tests use readdir() to create test cases, and sometimes
object to the contents of test.out.$$. However, as lib-http is also
sensitive to certain characters in the filenames of the files it uses,
we can hide the valgrind output by chosing its filename to exclude it
from the lib_http tests. Non-initial '~' is not known to cause any issues
for either the shell or any known operating system, so is the safest of
lib-http's 'dodgy' characters to use as the separator.

Signed-off-by: Phil Carmody <phil@dovecot.fi>
  • Loading branch information
Phil Carmody committed Aug 30, 2018
1 parent ef47c3d commit 52c1c99
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion m4/dovecot.m4
Expand Up @@ -60,7 +60,7 @@ if test "\$NOVALGRIND" != ""; then
\$[*]
ret=\$?
else
test_out="test.out.\$\$"
test_out="test.out~\$\$"
trap "rm -f \$test_out" 0 1 2 3 15
supp_path="\$top_srcdir/run-test-valgrind.supp"
if test -r "\$supp_path"; then
Expand Down

0 comments on commit 52c1c99

Please sign in to comment.