lib-auth: Require being connected before adding requests

dovecot · Mar 13, 2018 · 5403eb2 · 5403eb2
1 parent 6e1e25e
commit 5403eb2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/lib-auth/auth-server-connection.c b/src/lib-auth/auth-server-connection.c
@@ -472,6 +472,8 @@ auth_server_connection_add_request(struct auth_server_connection *conn,
 {
 	unsigned int id;
 
+	i_assert(conn->handshake_received);
+
 	id = ++conn->client->request_id_counter;
 	if (id == 0) {
 		/* wrapped - ID 0 not allowed */

diff --git a/src/lib-auth/auth-server-connection.h b/src/lib-auth/auth-server-connection.h
@@ -36,6 +36,7 @@ int auth_server_connection_connect(struct auth_server_connection *conn);
 void auth_server_connection_disconnect(struct auth_server_connection *conn,
 				       const char *reason);
 
+/* Queues a new request. Must not be called if connection is not connected. */
 unsigned int
 auth_server_connection_add_request(struct auth_server_connection *conn,
 				   struct auth_client_request *request);