lib-storage: Optimize error handling for SORT

If a lot of mails have failed in a large mailbox, this check reduces the CPU usage significantly.
dovecot · Jun 9, 2017 · 5954998 · 5954998
1 parent 521d502
commit 5954998
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/lib-storage/index/index-sort-string.c b/src/lib-storage/index/index-sort-string.c
@@ -355,6 +355,11 @@ index_sort_get_string(struct sort_string_context *ctx,
 	uint32_t seq = node->seq;
 	int ret = 1;
 
+	if (node->no_update) {
+		/* we've already determined that we can't do this lookup */
+		return FALSE;
+	}
+
 	if (ctx->sort_strings[seq] == NULL) T_BEGIN {
 		string_t *str;
 		const char *result;