Skip to content

Commit

Permalink
dsync: Fixed assert-crash if mailbox_attribute_set() fails
Browse files Browse the repository at this point in the history
We shouldn't set importer->mail_error, because we're not going to
fail the import.

Fixes assert-crash:
dsync-mailbox-import.c: line 2812 (dsync_mailbox_import_deinit): assertion failed: (importer->failed == (importer->mail_error != 0))
  • Loading branch information
sirainen committed May 3, 2016
1 parent 527dad0 commit 5f50fec
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/doveadm/dsync/dsync-mailbox-import.c
Expand Up @@ -523,7 +523,7 @@ dsync_mailbox_import_attribute_real(struct dsync_mailbox_importer *importer,
attr->key, &value) < 0) {
i_error("Mailbox %s: Failed to set attribute %s: %s",
mailbox_get_vname(importer->box), attr->key,
mailbox_get_last_error(importer->box, &importer->mail_error));
mailbox_get_last_error(importer->box, NULL));
/* the attributes aren't vital, don't fail everything just
because of them. */
}
Expand Down

0 comments on commit 5f50fec

Please sign in to comment.