lib-imap-storage: Don't sort uninitialized array on invalid header list.

dovecot · May 18, 2016 · 76d21e3 · 76d21e3
1 parent 564b73a
commit 76d21e3
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/lib-imap-storage/imap-msgpart.c b/src/lib-imap-storage/imap-msgpart.c
@@ -166,13 +166,12 @@ imap_msgpart_get_header_fields(pool_t pool, const char *header_list,
 			value = p_strdup(pool, t_str_ucase(value));
 			array_append(fields, &value, 1);
 		}
+		/* istream-header-filter requires headers to be sorted */
+		array_sort(fields, i_strcasecmp_p);
 	} else {
 		result = -1;
 	}
 
-	/* istream-header-filter requires headers to be sorted */
-	array_sort(fields, i_strcasecmp_p);
-
 	imap_parser_unref(&parser);
 	i_stream_unref(&input);
 	return result;