lib: net: Avoid comparing the content of unassigned IPs in net_ip_cmp().

dovecot · Mar 12, 2018 · 7b8354f · 7b8354f
1 parent 050b6ae
commit 7b8354f
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/lib/net.c b/src/lib/net.c
@@ -59,10 +59,15 @@ int net_ip_cmp(const struct ip_addr *ip1, const struct ip_addr *ip2)
 	if (ip1->family != ip2->family)
 		return ip1->family - ip2->family;
 
-	if (ip1->family == AF_INET6)
+	switch (ip1->family) {
+	case AF_INET6:
 		return memcmp(&ip1->u.ip6, &ip2->u.ip6, sizeof(ip1->u.ip6));
-
-	return memcmp(&ip1->u.ip4, &ip2->u.ip4, sizeof(ip1->u.ip4));
+	case AF_INET:
+		return memcmp(&ip1->u.ip4, &ip2->u.ip4, sizeof(ip1->u.ip4));
+	default:
+		break;
+	}
+	return 0;
 }
 
 unsigned int net_ip_hash(const struct ip_addr *ip)